Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepopulate theFirefox Versionfield for Nimbus #2948

Closed
AnaMedinac opened this issue Jun 30, 2020 · 6 comments
Closed

Prepopulate theFirefox Versionfield for Nimbus #2948

AnaMedinac opened this issue Jun 30, 2020 · 6 comments
Assignees
Labels
Blocked Enhancement new / change to feature or function https://mozilla.github.io/task-defect-enhancement/index.html Needs Design Issues that require design feedback before they can be worked on or closed Nimbus-Experimenter For syncing with Jira Tricky Web UI

Comments

@AnaMedinac
Copy link

AnaMedinac commented Jun 30, 2020

Is it possible to pre-populate the Firefox Version field in the rapid experiments form with the current Firefox Version. This way it's automatically filled in and the user doesn't have to worry about this field unless they're concerned with the version.

┆Issue is synchronized with this Jira Task
┆Issue Number: EXP-193

@jaredlockhart
Copy link
Collaborator

@AnaMedinac Right now there's no way to determine what the 'current firefox version' is inside Experimenter, so if you wanted it to behave that way I'd suggest sticking a placeholder in that literally says 'Current Version' and links out to the release calendar.

Side note, I'm confused about what this field does. Is it the minimum or maximum version? Does it correlate to the channel specified in the audience?

@jaredlockhart jaredlockhart added Blocked Enhancement new / change to feature or function https://mozilla.github.io/task-defect-enhancement/index.html Web UI labels Jun 30, 2020
@jaredlockhart
Copy link
Collaborator

Let's close this and go with users being intentional about which specific versions they intend to target.

@jaredlockhart jaredlockhart reopened this Jul 15, 2020
@jaredlockhart jaredlockhart added the Needs Design Issues that require design feedback before they can be worked on or closed label Jul 15, 2020
@pdehaan
Copy link
Contributor

pdehaan commented Jul 15, 2020

(formerly #3043 (comment))

Currently looks like:

Mozilla_Experimenter

I think my concerns are if Firefox 83 is release, we'd have ~6 old builds at the top of the list that don't make sense. Or each new experiment would always have to select the correct Release version from a dropdown. Or if you mistakenly select "Firefox 94.0" from the dropdown (because reasons), the experiment would launch (if not caught+rejected by an operator), but nothing would happen because even after your enrollment+test period, that version would never be in scope and you'd presumably get no results back.

But yeah, maybe its too tricky to scrape the list of current trains from https://whattrainisitnow.com/ (or the upstream https://product-details.mozilla.org/1.0/firefox_versions.json which is where they apparently fetch from). Having a pseudo-dynamic list of dropdown values adds a lot of weird edges.
I just didn't know if a select list with only 3 options:

  • "Release Firefox 78.0"
  • "Beta Firefox 79.0"
  • "Nightly Firefox 80.0"

... would make it easier an easier UX for experiment submitters. Since we only ever show 3 options, "Release" would always be the first/default option and what submitters would want 99.99% of the time anyways.

@jaredlockhart
Copy link
Collaborator

Blocked on design input from @AnaMedinac and @k88hudson

@k88hudson
Copy link
Contributor

k88hudson commented Jul 16, 2020

I agree with @AnaMedinac's original comment that we should set the default value to the current release. I think it would also be good to indicate that in the UI as well (maybe the words "current release"?).

What other design input are you looking for, or are you just looking to reconfirm @jaredlockhart? Would it be doable to read that value from https://product-details.mozilla.org/1.0/firefox_versions.json?

@k88hudson k88hudson added the Nimbus-Experimenter For syncing with Jira label Aug 10, 2020
@k88hudson k88hudson changed the title Prepoluate the Firefox Version field in the rapid experiments form Prepopulate the Firefox Versionfield for Nimbus Aug 10, 2020
@k88hudson k88hudson changed the title Prepopulate the Firefox Versionfield for Nimbus Prepopulate theFirefox Versionfield for Nimbus Aug 10, 2020
@pdehaan pdehaan added the Tricky label Aug 18, 2020
@k88hudson k88hudson self-assigned this Aug 18, 2020
@k88hudson
Copy link
Contributor

@k88hudson I will discuss options with @jaredlockhart in our next pairing session

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Enhancement new / change to feature or function https://mozilla.github.io/task-defect-enhancement/index.html Needs Design Issues that require design feedback before they can be worked on or closed Nimbus-Experimenter For syncing with Jira Tricky Web UI
Projects
None yet
Development

No branches or pull requests

4 participants