Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use typescript-eslint parser for rapid .eslintrcjs #2834

Closed
k88hudson opened this issue Jun 16, 2020 · 1 comment · Fixed by #3062
Closed

Use typescript-eslint parser for rapid .eslintrcjs #2834

k88hudson opened this issue Jun 16, 2020 · 1 comment · Fixed by #3062
Labels
P5 - Low Priority we would take a fix - but we aren't planning to fix near-term Every 6 months re-triage for closing Task https://mozilla.github.io/task-defect-enhancement/index.html

Comments

@k88hudson
Copy link
Contributor

Since we are using typescript-eslint rules, it would be a good idea to use the @typescript-eslint/parser for the parser setting in .eslintrc.

See https://github.com/typescript-eslint/typescript-eslint#what-about-babel-and-babel-eslint

The key trade-off can be summarized as babel-eslint supports additional syntax which TypeScript itself does not, but typescript-eslint supports creating rules based on type information, which is not available to babel because there is no type-checker.

Because they are separate projects powered by different underlying tooling, they are currently not intended to be used together.
@jaredlockhart
Copy link
Collaborator

Change here: https://github.com/mozilla/experimenter/blob/main/app/experimenter/static/rapid/.eslintrc.js#L7

@jaredlockhart jaredlockhart added Task https://mozilla.github.io/task-defect-enhancement/index.html P5 - Low Priority we would take a fix - but we aren't planning to fix near-term Every 6 months re-triage for closing labels Jun 30, 2020
@bhushan-borole bhushan-borole mentioned this issue Jul 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P5 - Low Priority we would take a fix - but we aren't planning to fix near-term Every 6 months re-triage for closing Task https://mozilla.github.io/task-defect-enhancement/index.html
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use typescript-eslint parser for rapid .eslintrcjs
2 participants
@jaredlockhart @k88hudson