for some reason command make schemas_generate is only changing the .ts file but not generating the json file

I don't think we should add a whole new module for this. Instead, can we define v7 API mixins and make a class that inherits from the v6 API schemas and the mixins?

yeah @mikewilli and I were discussing this too, for the first approach we kept out separately

I don't think we should add a whole new module for this. Instead, can we define v7 API mixins and make a class that inherits from the v6 API schemas and the mixins?

yeah @mikewilli and I were discussing this too, for the first approach we kept out separately

I don't feel strongly either way, but it seems like there's a lot of duplication here so @brennie's suggestion makes sense to me.

thank you both @mikewilli @brennie , I was thinking of keeping v7 separately but reusing the v6 code, does it seem to be the right approach?

thank you both @mikewilli @brennie , I was thinking of keeping v7 separately but reusing the v6 code, does it seem to be the right approach?

Yeah its fine to keep the v7 api separate. Maybe we rename the module experimenter_apis or something? And then rename the top level object the experimenter_apis.ExperimentV7 ?

Not worth blocking approval, but did you consider the V7-at-the-end naming?

Otherwise LGTM!

done, v7 at the end now

Thanks everyone for hopping on this, I think it's all looking good, but I'm confused about one thing. I see that there's a folder for v7 fixtures that includes desktop recipe examples, but v7 isn't used in the client and doesn't need to maintain any client compatibility or backwards compatibility, so I'm confused about why that's there?

Thanks everyone for hopping on this, I think it's all looking good, but I'm confused about one thing. I see that there's a folder for v7 fixtures that includes desktop recipe examples, but v7 isn't used in the client and doesn't need to maintain any client compatibility or backwards compatibility, so I'm confused about why that's there?

I wasn't sure about the scope of the v7 usage, just added those in case. do you think I should take it out @jaredlockhart?

Since V7 isn't consumed by clients

* We don't need special cases for desktop/sdk

* We don't need to test against client recipes

* Let's have a sample fixture for v7 as well, but it's actually separate from the existing client fixtures, just generate a factory locally, run it through v7, snapshot that.

And let's keep naming consistent so if we're going to identify things v7 we should also identify things as v6.

I'm against renaming the v6 to have "V6" since they're the canonical representations (and also means we'd have to update our clients to look for new schemas)

I like the idea of separating the schemas into experiments schemas and API schemas (i.e., schemas/experiments/, schemas/experimenter_api/v7.py or similar).

@jaredlockhart @freshstrangemusic I removed the client from v7, I haven't changed the old one to v6 as Beth mentioned that clients need to make changes too, let me know if its necessary I am happy to rename that too v6