Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When failing during workflow.run, post a generic failure like we do during events #984

Closed
marco-c opened this issue Sep 23, 2021 · 0 comments · Fixed by #986
Closed

When failing during workflow.run, post a generic failure like we do during events #984

marco-c opened this issue Sep 23, 2021 · 0 comments · Fixed by #986
Assignees
Labels
bot Code review bot

Comments

@marco-c
Copy link
Collaborator

marco-c commented Sep 23, 2021

When an exception is thrown during the bot workflow, we report a build failure without any additional information:

w.update_status(revision, state=BuildState.Fail)
.

We should instead add at least a message like events does in case of generic failures:

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot Code review bot
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants