Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dragging files/dirs around in the file tree with (deeply) nested relocation #449

Open
gideonthomas opened this issue Sep 1, 2015 · 6 comments

Comments

@gideonthomas
Copy link

We should support drag 'n drop into deep file tree structures and provide a way to rearrange the file tree with the UI.

See https://github.com/mozilla/thimble.webmaker.org/issues/1002

@borisrorsvort
Copy link

👍 🎉

@humphd
Copy link

humphd commented Mar 23, 2017

I've been rewriting a bunch of this code lately, and I don't think it's likely we'll do drag-and-drop rearranging of the file tree. We probably can do drag-into-a-folder though, which is https://github.com/mozilla/thimble.mozilla.org/issues/1886. I'm going to close this.

@humphd humphd closed this as completed Mar 23, 2017
@humphd
Copy link

humphd commented Mar 29, 2017

Since I closed this, I've actually been rethinking my position. Based on subsquent work I've done, I actually think this wouldn't be too hard to implement.

I'm trying to decide whether it's worth doing here or upstream in Adobe's Brackets. Some recent discussion about their bug(s) on this here adobe#12101 (comment)

@humphd humphd reopened this Mar 29, 2017
@Pomax
Copy link

Pomax commented Apr 3, 2017

given the ambiguity around the words "drag and drop" (which can either mean on-page or from-desktop-into-page), is this issue specifically about dragging files/directories around in the file tree? If so, that feels like a thing brackets should support (and I'd be surprised if brackets itself doesn't already)

@humphd
Copy link

humphd commented Apr 3, 2017

It's about dragging within the filetree to move files from one folder to another. Brackets does not support it, but has various bugs filed on this (people want it). I included a link above. Fixing this upstream in Brackets itself is one way to go. It would be more complicated than just doing it for our case, since we only have to work on a single filesystem (i.e., Filer).

@Pomax Pomax changed the title DnD into deep dirs dragging files/dirs around in the file tree with (deeply) nested relocation Apr 3, 2017
@humphd
Copy link

humphd commented Apr 20, 2017

A note for myself on impl of this: https://reactjsnews.com/complex-drag-and-drop-lists-using-react

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants