Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with 404s in filer-dialogs extension #113

Closed
humphd opened this issue Mar 18, 2015 · 5 comments
Closed

Deal with 404s in filer-dialogs extension #113

humphd opened this issue Mar 18, 2015 · 5 comments
Assignees

Comments

@humphd
Copy link

humphd commented Mar 18, 2015

screen shot 2015-03-18 at 12 31 25 pm

The filer-dialogs extension adds File > Open and File > Save As dialogs for our filer filesystem. It needs a build step to install fonts from font-awesome using bower. We don't have that in our Gruntfile, so our dist/ is missing those CSS files. Also, we probably aren't copying them over properly.

This should get fixed.

@humphd humphd added this to the PPP.1 milestone Mar 23, 2015
@sedge
Copy link

sedge commented Mar 27, 2015

Do we want to remove font-awesome completely?

@humphd
Copy link
Author

humphd commented Mar 27, 2015

Well, we are now using it for the gutter icon in HTMLHinter. So I say we start by making this work. Can we do this in such a way that we make sure we only load it once? And only load the smallest set of what is needed for our icon use? Keep an eye on overall size increases.

@gideonthomas
Copy link

Seems like HTMLHinter is going to be using an image instead!

@gideonthomas gideonthomas assigned sedge and unassigned sedge Apr 2, 2015
@gideonthomas gideonthomas removed this from the PPP.1 milestone Apr 2, 2015
@humphd
Copy link
Author

humphd commented May 26, 2015

This is fixed now, can we close? @gideonthomas

@gideonthomas
Copy link

Well, I don't think this is technically fixed. It just doesn't show up anymore because we stopped using filer-dialogs in humphd/brackets@9929a0c

@sedge sedge added this to the Heartbeat 2 - The 1Mb challenge milestone May 27, 2015
@sedge sedge closed this as completed May 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants