This repository has been archived by the owner on Jul 5, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 98
[Crash] TabTrayFragment.java line 195 #4942
Labels
Comments
I've reproduced this issue twice
|
cnevinc
added a commit
that referenced
this issue
Apr 29, 2020
If we want to initialize HomeViewModel using the old method, the depedencies won't be ready so it'll choose the zero parameter constructor. Since we use Dagger to inject HomeViewModel and its depedencies, we should do the same here. The reason why previous versions won't crash is because HomeFragment will always be visible first. But if we turn on "Don't keep activity" and resume the app while Tab Tray is previously showing, this trash will happen.
Update the 100% reproduce steps
|
verify: ✅
result: see tab tray correctly |
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Describe the bug
crashes 636 ; user affected 129
https://console.firebase.google.com/u/0/project/zerda-dcf76/crashlytics/app/android:org.mozilla.rocket/issues/844c4fc80faf3a0244a9d171894a7a23?time=last-seven-days&sessionId=5EA981D3019700013C95C76274423FEA_DNE_0_v2
Device info (please complete the following information):
This only happens on Version 2.1.16(19398)
The text was updated successfully, but these errors were encountered: