Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README to use Docker #135

Open
2 tasks
say-yawn opened this issue Mar 11, 2020 · 1 comment
Open
2 tasks

Update README to use Docker #135

say-yawn opened this issue Mar 11, 2020 · 1 comment

Comments

@say-yawn
Copy link
Contributor

About this PR

As mentioned in this comment the current README is not up to date with tools we are currently using. Additionally, using virtualenv without the correct configuration is resulting into packages being downloaded within the Shavar codebase. We should use #73 and the latest updates to README from #131 as source to update README with docker setup.

Acceptance Criteria

  • Remove use of virtualenv in dev environment setup in README
  • Use Docker for dev environment setup in README
@say-yawn say-yawn mentioned this issue Mar 11, 2020
Merged
1 task
@LilyLME LilyLME mentioned this issue Mar 21, 2020
Open
@LilyLME
Copy link

LilyLME commented Mar 21, 2020

@skim1102 I would like to work on this, I noticed there is a similar problem in shavar-list-creation virtualenv created it's files over the project source. I had to delete and give it a custom name out of the directory.

@boolean5 boolean5 mentioned this issue Mar 24, 2020
Open
@LilyLME LilyLME mentioned this issue Mar 26, 2020
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@say-yawn @LilyLME