From c3c0f9415829add42eb3b08138efe43b2c806a86 Mon Sep 17 00:00:00 2001 From: Julien Cristau Date: Wed, 18 Dec 2024 16:26:54 +0100 Subject: [PATCH] ci: don't hide tc-admin stderr (#233) tc-admin diff uses the same exit code (1) both for "there was an error" and "I found differences", so its error output is basically the only way we can differentiate currently. --- taskcluster/fxci_config_taskgraph/optimizations.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/taskcluster/fxci_config_taskgraph/optimizations.py b/taskcluster/fxci_config_taskgraph/optimizations.py index f6a3f3a1..3341ceaf 100644 --- a/taskcluster/fxci_config_taskgraph/optimizations.py +++ b/taskcluster/fxci_config_taskgraph/optimizations.py @@ -28,7 +28,7 @@ def _get_modified_worker_pools(self) -> set[str]: ] env = os.environ.copy() env["TASKCLUSTER_ROOT_URL"] = FIREFOXCI_ROOT_URL - proc = subprocess.run(cmd, capture_output=True, text=True, env=env) + proc = subprocess.run(cmd, stdout=subprocess.PIPE, text=True, env=env) lines = [line for line in proc.stdout.splitlines() if line.startswith("!")] worker_pools = set()