Skip to content
This repository has been archived by the owner on Apr 27, 2023. It is now read-only.

demographic survey: expectations from frontend do not match expectation from background script so incomplete survey results are being dropped from endpoint #628

Closed
hamilton opened this issue May 29, 2021 · 0 comments · Fixed by #636
Assignees
Labels
bug Something isn't working effort XS Expected to take a day or less for engineering.

Comments

@hamilton
Copy link
Contributor

hamilton commented May 29, 2021

The background script expects the demographic survey to not have fields if a question goes unanswered, but the frontend does not have this requirement. As such, invalid surveys are hitting the tables with errors, causing surveys to drop when (for example) someone doesn't answer the age question in the survey.

If all questions are answered by a panel member, then the survey arrives at the pioneer-core survey table as expected.

Since this has apparently been an issue since we launched RS01, I put together a branch that should resolve this issue and align the frontend to the submission structure. It will not change the background script but instead refactors the demographic survey frontend to match the expectation the schema has.

This should be a top priority for fixing Tuesday morning when everyone is back.

@hamilton hamilton added the bug Something isn't working label May 29, 2021
@hamilton hamilton changed the title demographic survey: expectations from frontend do not match expectation from background script so survey results are being dropped demographic survey: expectations from frontend do not match expectation from background script so survey results are being dropped from endpoint May 29, 2021
@hamilton hamilton changed the title demographic survey: expectations from frontend do not match expectation from background script so survey results are being dropped from endpoint demographic survey: expectations from frontend do not match expectation from background script so incomplete survey results are being dropped from endpoint May 29, 2021
@hamilton hamilton added the effort XS Expected to take a day or less for engineering. label Jun 1, 2021
@hamilton hamilton self-assigned this Jun 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working effort XS Expected to take a day or less for engineering.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant