Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] Connection Information elements are not narrated by the screen reader #8423

Closed
data-sync-user opened this issue Oct 30, 2023 · 8 comments
Labels
bug Something isn't working

Comments

@data-sync-user
Copy link
Collaborator

Important details:

  • The issue is not reproducible when navigating backwards, using CAPS+U key combination.
  • Not reproducing on macOS;

Affected versions:

  • 2.19.0 (2.202310280712);

Tested Platforms:

  • Windows;

Prerequisites:

  • Have an account with an active subscription for Mozilla VPN;

  • Be signed in;

  • Turn VPN on;

  • Be in Connection Information screen

Steps to reproduce:

  1. Using the keyboard, navigate in the Connection Information screen (TAB/SHIFT + TAB, CAPS +O).
  2. Observe how the elements are narrated.

Expected result:

  • All elements in the Connection Information screen are narrated.

Actual result:

  • Connection Information title and exit server are not narrated when using TAB/SHIFT+TAB/CAPS+O key combinations.

┆Issue is synchronized with this Jira Bug
┆Reporter: Raluca Monica Ilban

@data-sync-user data-sync-user added the bug Something isn't working label Oct 30, 2023
@data-sync-user
Copy link
Collaborator Author

➤ Vinoo Cherian commented:

Fixed by https://mozilla-hub.atlassian.net/browse/VPN-5597 ( https://mozilla-hub.atlassian.net/browse/VPN-5597|smart-link )

Most of the content in the connection screen are text elements, so TAB/Shift+TAB cannot be used to navigate to them. However, CapsLock + O (Read next line) and CapsLock + U (Read previous line) or CapsLock + LeftArrow (Move to previous item) and CapsLock + RightArrow (Move to next item) can be used navigate to those text element.

@data-sync-user
Copy link
Collaborator Author

➤ Bianca Hidecuti commented:

Verified this on Mozilla VPN 2.19.0 (2.202311181616), using Windows 10/11, and the following were observed:

  • when the entire app window is in focus, text elements from the CI screen are narrated;
  • when navigating backwards, using CAPS + U / CAPS + left arrow, text elements from the CI screen are narrated;
  • when navigation using CAPS + O / CAPS + right arrow, text elements from the CI screen are still NOT narrated;
    • text elements are narrated when navigating forward only if the user navigated backwards previously and the ‘Connection inforation’ text element is in focus;

Based on the above, it seems that the behavior did not change at all after the fix. Vinoo Cherian, could you please take a look at this? Thank you!

Attaching a video with the behavior as well.

!bandicam 2023-11-20 11-09-32-825.mp4|width=1152,height=896!

@data-sync-user
Copy link
Collaborator Author

➤ Vinoo Cherian commented:

Bianca Hidecuti, sorry, I misunderstood this issue. It looks like this one is about the order of navigation. This navigation order is currently by design because the close button is the last element in the Connection Information screen, so the user needs to navigate backwards to access the other elements. The design looks broken. I’m looking closer to see how this can be fixed.

@data-sync-user
Copy link
Collaborator Author

➤ Vinoo Cherian commented:

Fixed the navigation order so that CapsLock + O (Read next line) or CapsLock + Right Arrow (Move to next item) from the Close button will navigate to the text elements in the Connection Info panel. Note that TAB cannot be used to navigate to text elements. Also fixed tab order on home screen so the user navigates left to right and top to bottom.

@data-sync-user
Copy link
Collaborator Author

➤ Raluca Monica Ilban commented:

Verified on Mozilla VPN 2.19.0 (2.202311211907), using Windows.

  • on the CI screen, all elements are narrated when navigating forward and backward (Caps+O/Caps+U/Caps+Right Arrow/Caps+Left Arrow)
  • on the home screen, when the VPN is off, the subtitle is skipped when navigating via keyboard. The title "VPN is off" is focused and narrated, and the next element that gets focus is the toggle.
    When the VPN is turned off, then the title and subtitle are being narrated.
    The issue is not reproducible when the VPN is on, in this case the subtitle gets focus and is narrated.
    Should we track this in a separate ticket?

@data-sync-user
Copy link
Collaborator Author

➤ Vinoo Cherian commented:

Raluca Monica Ilban , yes, please track the subtitle issue on the home screen in a separate ticket. Thanks.

@data-sync-user
Copy link
Collaborator Author

➤ Raluca Monica Ilban commented:

Thank you.

I am marking this verified as fixed, based on the previous comment.
We will verify the subtitle issue with https://mozilla-hub.atlassian.net/browse/VPN-5293 ( https://mozilla-hub.atlassian.net/browse/VPN-5293|smart-link )

@data-sync-user
Copy link
Collaborator Author

➤ Raluca Monica Ilban commented:

Hi Vinoo Cherian ,

Why was the fix version changed to 2.20 since it was already verified as fixed in 2.19?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant