diff --git a/src/networkwatcherimpl.h b/src/networkwatcherimpl.h index 85c34e5af4..07ec36acf2 100644 --- a/src/networkwatcherimpl.h +++ b/src/networkwatcherimpl.h @@ -24,7 +24,6 @@ class NetworkWatcherImpl : public QObject { bool isActive() const { return m_active; } - ///@TODO should this be removed too? enum TransportType { TransportType_Unknown = 0, TransportType_Ethernet = 1, diff --git a/src/platforms/android/androidnetworkwatcher.cpp b/src/platforms/android/androidnetworkwatcher.cpp index fb4bdba464..25609b9f4c 100644 --- a/src/platforms/android/androidnetworkwatcher.cpp +++ b/src/platforms/android/androidnetworkwatcher.cpp @@ -16,9 +16,6 @@ namespace { Logger logger("AndroidNetworkWatcher"); - -// constexpr auto VPNNetworkWatcher_CLASS = -// "org/mozilla/firefox/vpn/qt/VPNNetworkWatcher"; } // namespace AndroidNetworkWatcher::AndroidNetworkWatcher(QObject* parent) diff --git a/src/telemetry/metrics.yaml b/src/telemetry/metrics.yaml index c7cc3e5560..71dec23e5e 100644 --- a/src/telemetry/metrics.yaml +++ b/src/telemetry/metrics.yaml @@ -1111,8 +1111,8 @@ sample: loss, stddev. type: string transport: - description: The Host network type (i.e wifi or 4g) - type: string + description: The Host network type (i.e wifi or 4g). Possible values are Unknown, Disconnected, Local, Site, Online + type: QNetworkInformation::Reachability connectivity_stable: type: event @@ -1148,8 +1148,8 @@ sample: description: Standard deviation of the ping responses type: string transport: - description: The Host network type (i.e wifi or 4g) - type: string + description: The Host network type (i.e wifi or 4g). Possible values are Unknown, Disconnected, Local, Site, Online + type: QNetworkInformation::Reachability server_unavailable_error: type: event