Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FXIOS-6662 [v117] Handle ETP coordinator transitioning Delegate #15568

Merged
merged 8 commits into from
Jul 24, 2023
Merged

Add FXIOS-6662 [v117] Handle ETP coordinator transitioning Delegate #15568

merged 8 commits into from
Jul 24, 2023

Conversation

aalaaeid
Copy link
Contributor

@aalaaeid aalaaeid commented Jul 13, 2023 •
edited by lmarceau
Loading

📜 Tickets

Jira ticket
Github issue

💡 Description

  1. this make the ETPCoordinator the transitioning delegate.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and ensured the tests suite is passing
  • Implemented accessibility and tested on UI related work (minimum Dynamic Text and VoiceOver)
  • Updated documentation / comments for complex code and public methods if needed

@aalaaeid aalaaeid requested a review from a team as a code owner July 13, 2023 18:25
@aalaaeid aalaaeid requested a review from yoanarios July 13, 2023 18:25
@lmarceau lmarceau changed the title Add FXIOS-14890 [v117] Handle ETP coordinator transitioning Delegate Add FXIOS-6662 [v117] Handle ETP coordinator transitioning Delegate Jul 17, 2023
@lmarceau
Copy link
Contributor

Almost there, Bitrise failed with:

❌  /Users/vagrant/git/Tests/ClientTests/Coordinators/BrowserCoordinatorTests.swift:661:48: missing argument for parameter 'sourceView' in call
        subject.showEnhancedTrackingProtection()

@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 34.26%
📖 Edited 6 files
📖 Created 0 files

Client.app: Coverage: 32.59

File Coverage
BrowserViewController+URLBarDelegate.swift 2.37% ⚠️
BrowserCoordinator.swift 89.07% ✅
BaseCoordinator.swift 100.0% ✅
EnhancedTrackingProtectionCoordinator.swift 79.17% ✅
BrowserNavigationHandler.swift 100.0% ✅

Generated by 🚫 Danger Swift against acbb487

@lmarceau lmarceau merged commit 2aa2058 into mozilla-mobile:main Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmarceau lmarceau lmarceau approved these changes

@yoanarios yoanarios Awaiting requested review from yoanarios yoanarios is a code owner automatically assigned from mozilla-mobile/fxios-eng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aalaaeid @lmarceau @mobiletest-ci-bot