Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Investigate UI Test false positive passes #12938

Closed
ekager opened this issue Jul 25, 2020 · 3 comments
Closed

Investigate UI Test false positive passes #12938

ekager opened this issue Jul 25, 2020 · 3 comments
Labels
eng:automation Build automation, Continuous integration, .. eng:ui-test UI Tests

Comments

@ekager
Copy link
Contributor

ekager commented Jul 25, 2020 •
edited by data-sync-user
Loading

A few times recently when PRs are closed/opened, CI will pass and a bad commit (meaning tests should have failed) will then land and reliably fail on master. Why is CI passing on these PRs 🤔

Examples:

┆Issue is synchronized with this Jira Task
@ekager ekager mentioned this issue Jul 25, 2020
Merged
4 tasks
@github-actions github-actions bot added the needs:triage Issue needs triage label Jul 25, 2020
@ekager ekager changed the title Investigate CI false positive passes Investigate UI Test false positive passes Jul 27, 2020
@ekager ekager added eng:automation Build automation, Continuous integration, .. and removed needs:triage Issue needs triage labels Jul 27, 2020
@ekager
Copy link
Contributor Author

ekager commented Jul 27, 2020

cc @rpappalax is this something your team can take a look at?

@ekager ekager added the eng:ui-test UI Tests label Jul 27, 2020
@ekager
Copy link
Contributor Author

ekager commented Jul 30, 2020 •
edited
Loading

Apparently this is a Flank issue with the recent update Flank/flank#917
We are waiting for a new release

@AaronMT
Copy link
Contributor

AaronMT commented Aug 6, 2020

Should be fixed with Flank v20.08.0

4b87f16

@AaronMT AaronMT closed this as completed Aug 6, 2020
@data-sync-user data-sync-user changed the title Investigate UI Test false positive passes FNX3-21982 ⁃ Investigate UI Test false positive passes Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-21982 ⁃ Investigate UI Test false positive passes FNX-14081 ⁃ Investigate UI Test false positive passes Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-14081 ⁃ Investigate UI Test false positive passes FNX2-15560 ⁃ Investigate UI Test false positive passes Aug 11, 2020
@ekager ekager closed this as completed Aug 26, 2020
@data-sync-user data-sync-user changed the title FNX2-15560 ⁃ Investigate UI Test false positive passes Investigate UI Test false positive passes May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
eng:automation Build automation, Continuous integration, .. eng:ui-test UI Tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AaronMT @ekager @data-sync-user