Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Clean-up PromptFeature #9752

Closed
grigoryk opened this issue Feb 22, 2021 · 1 comment
Closed

Clean-up PromptFeature #9752

grigoryk opened this issue Feb 22, 2021 · 1 comment
Labels
<autofill> Credit Card, Addresses and Logins autofill functionality E5 Estimation points: 5

Comments

@grigoryk
Copy link
Contributor

grigoryk commented Feb 22, 2021 •
edited by data-sync-user
Loading

In preparation for #9457 we need to clean-up PromptFeature.

Currently I'm thinking about splitting out login stuff into LoginPromptFeature, which will pave the way for CreditCardPromptFeature and AddressesPromptFeature, keeping the central class pretty lightweight.

┆Issue is synchronized with this Jira Task
@grigoryk grigoryk added the <autofill> Credit Card, Addresses and Logins autofill functionality label Feb 22, 2021
@grigoryk grigoryk self-assigned this Feb 22, 2021
@gabrielluong gabrielluong added <cc> E5 Estimation points: 5 labels Mar 2, 2021
@gabrielluong gabrielluong mentioned this issue Mar 16, 2021
Closed
4 tasks
@gabrielluong gabrielluong mentioned this issue May 31, 2021
Closed
@grigoryk grigoryk removed their assignment Nov 3, 2021
@grigoryk
Copy link
Contributor Author

grigoryk commented Nov 3, 2021

This code has evolved and my old patches bitrotted. Closing the issue for now, more relevant details in #10323 (comment)

@grigoryk grigoryk closed this as completed Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
<autofill> Credit Card, Addresses and Logins autofill functionality E5 Estimation points: 5
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@grigoryk @gabrielluong @jonalmeida