Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete files (PR467) #470

Closed
peiying2 opened this issue Jan 7, 2025 · 3 comments
Closed

Remove obsolete files (PR467) #470

peiying2 opened this issue Jan 7, 2025 · 3 comments
Assignees
@flodolo

Comments

@peiying2
Copy link
Contributor

peiying2 commented Jan 7, 2025

Remove the following 6 files localized files for impacted locales per PR 467.

  • Firefox/all.ftl
  • Firefox/features/adblocker.ftl
  • Firefox/nightly/whatsnew.ftl
  • mozorg/newsletters.ftl
  • navigation.ftl
  • newsletter_form.ftl
@flodolo flodolo mentioned this issue Jan 7, 2025
Merged
@flodolo
Copy link
Contributor

flodolo commented Jan 7, 2025

Actually, #469 is removing files that were removed in #464.

My script is not removing these 🤔

@flodolo
Copy link
Contributor

flodolo commented Jan 7, 2025

@peiying2

Is this issue correct? #467 is removing strings, not removing files. Example: https://github.com/mozilla-l10n/www-l10n/blob/master/en/firefox/all.ftl

@peiying2
Copy link
Contributor Author

peiying2 commented Jan 7, 2025

Oh my gosh!! Near catastrophic request! Glad you asked - PR467 was for the removal of old strings. Let's close this PR. Thank you for checking!

@peiying2 peiying2 closed this as completed Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flodolo flodolo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flodolo @peiying2