From 328d6d77138e947b0b9fc247d75086a48b27f775 Mon Sep 17 00:00:00 2001 From: Ian Bicking Date: Thu, 19 Sep 2019 13:32:13 -0500 Subject: [PATCH] Fix #190, open site-specific searches in a new tab Also allow 'in' in addition to 'on' in site-specific searches, like 'in Gmail' --- extension/intents/navigation/navigation.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/extension/intents/navigation/navigation.js b/extension/intents/navigation/navigation.js index 15ab5df88..c826c5a1a 100644 --- a/extension/intents/navigation/navigation.js +++ b/extension/intents/navigation/navigation.js @@ -40,12 +40,13 @@ this.intents.navigation = (function() { name: "navigation.bangSearch", match: ` (do a |) (search | query | look up | lookup | look on | look for) (my |) [service:serviceName] (for | for the |) [query] - (do a |) (search | query | find | find me | look up | lookup | look on | look for) (my | on | for |) (the |) [query] on [service:serviceName] + (do a |) (search | query | find | find me | look up | lookup | look on | look for) (my | on | for | in |) (the |) [query] (on | in) [service:serviceName] `, examples: [ "Search my Gmail for tickets to Hamilton", "Look up The Book Thief on GoodReads", "Search CSS grid on MDN", + "Look up Hamilton in Gmail", ], async run(desc) { const myurl = await searching.ddgBangSearchUrl( @@ -55,7 +56,7 @@ this.intents.navigation = (function() { desc.addTelemetryServiceName( `ddg:${services.ddgBangServiceName(desc.slots.service)}` ); - await browser.tabs.update({ url: myurl }); + await browser.tabs.create({ url: myurl }); browser.runtime.sendMessage({ type: "closePopup", sender: "find",