fix demos #493
Merged
fix demos #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- orbit view centered at workspace instead of 2d orbit - REALTIME trajectory display
- verify default state (exists right now) - use model frame over virtual "world" which is not known in fresh PlanningScene - ignore initial collisions with the IK seed
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #493 +/- ##
=======================================
Coverage 59.01% 59.01%
=======================================
Files 90 90
Lines 8484 8484
=======================================
Hits 5006 5006
Misses 3478 3478 ☔ View full report in Codecov by Sentry. |
LeroyR
pushed a commit
to CentralLabFacilities/moveit_task_constructor
that referenced
this pull request
Oct 26, 2023
* improve demo rviz config - orbit view centered at workspace instead of 2d orbit - REALTIME trajectory display * FixedState: setter for ignore_collisions property * Fix clearance_cost demo - verify default state - use model frame over virtual "world" which is not known in fresh PlanningScene - ignore initial collisions with the IK seed * improve documentation in Fallbacks demo
v4hn
added a commit
to v4hn/moveit_task_constructor
that referenced
this pull request
Nov 28, 2023
* improve demo rviz config - orbit view centered at workspace instead of 2d orbit - REALTIME trajectory display * FixedState: setter for ignore_collisions property * Fix clearance_cost demo - verify default state - use model frame over virtual "world" which is not known in fresh PlanningScene - ignore initial collisions with the IK seed * improve documentation in Fallbacks demo
captain-yoshi
pushed a commit
to captain-yoshi/moveit_task_constructor
that referenced
this pull request
Feb 8, 2024
* improve demo rviz config - orbit view centered at workspace instead of 2d orbit - REALTIME trajectory display * FixedState: setter for ignore_collisions property * Fix clearance_cost demo - verify default state - use model frame over virtual "world" which is not known in fresh PlanningScene - ignore initial collisions with the IK seed * improve documentation in Fallbacks demo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking through the demos I stumbled across a few things to improve and some bit rot that needed polishing.