Skip to content

Commit

Permalink
Remove display_motion_plans and publish_planning_requests properties (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
sjahr authored Oct 10, 2023
1 parent 5c4ef60 commit b25d2ba
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 14 deletions.
2 changes: 0 additions & 2 deletions core/python/bindings/src/solvers.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,6 @@ void export_solvers(py::module& m) {
.property<double>("goal_joint_tolerance", "float: Tolerance for reaching joint goals")
.property<double>("goal_position_tolerance", "float: Tolerance for reaching position goals")
.property<double>("goal_orientation_tolerance", "float: Tolerance for reaching orientation goals")
.property<bool>("display_motion_plans", "bool: Publish generated solutions via a topic")
.property<bool>("publish_planning_requests", "bool: Publish motion planning requests via a topic")
.def(py::init<const std::string&>(), "pipeline"_a = std::string("ompl"));

properties::class_<JointInterpolationPlanner, PlannerInterface>(
Expand Down
12 changes: 0 additions & 12 deletions core/src/solvers/pipeline_planner.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,6 @@ PipelinePlanner::PipelinePlanner(
properties().declare<double>("goal_position_tolerance", 1e-4, "tolerance for reaching position goals");
properties().declare<double>("goal_orientation_tolerance", 1e-4, "tolerance for reaching orientation goals");
// Declare properties that configure the planning pipeline
properties().declare<bool>("display_motion_plans", false,
"publish generated solutions on topic " +
planning_pipeline::PlanningPipeline::DISPLAY_PATH_TOPIC);
properties().declare<bool>("publish_planning_requests", false,
"publish motion planning requests on topic " +
planning_pipeline::PlanningPipeline::MOTION_PLAN_REQUEST_TOPIC);
properties().declare<std::unordered_map<std::string, std::string>>(
"pipeline_id_planner_id_map", std::unordered_map<std::string, std::string>(),
"Set of pipelines and planners used for planning");
Expand Down Expand Up @@ -144,12 +138,6 @@ void PipelinePlanner::init(const core::RobotModelConstPtr& robot_model) {
throw std::runtime_error(
"Cannot initialize PipelinePlanner: Could not create any valid entries for planning pipeline maps!");
}

// Configure all pipelines according to the configuration in properties
for (auto const& name_pipeline_pair : planning_pipelines_) {
name_pipeline_pair.second->displayComputedMotionPlans(properties().get<bool>("display_motion_plans"));
name_pipeline_pair.second->publishReceivedRequests(properties().get<bool>("publish_planning_requests"));
}
}

bool PipelinePlanner::plan(const planning_scene::PlanningSceneConstPtr& from,
Expand Down

0 comments on commit b25d2ba

Please sign in to comment.