-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes pilz tests #3095
Fixes pilz tests #3095
Conversation
This one doesn't need backporting to humble, and I'll fix the iron tests along with the conflicts |
These failures seem unrelated to this PR as they're from moveit_core. I might suspect the original -- #3077 -- again, but that PR changes the implementation of |
@sjar @sea-bass PRs before #3077 also have shown the same errors (e.g. https://github.com/moveit/moveit2/actions/runs/11701726753/job/32588415027 and https://github.com/moveit/moveit2/actions/runs/11540595594/job/32121612716) Could this PR be added to the queue again? |
Description
This fixes an issue in some of the pilz tests introduced by #3077.
Instead of passing an empty map of subframes, we were passing a one-item map containing an empty pair, which was causing test errors when validating subframe isometries.
This is fixed by adding some explicit subframes to every such test, with the ones that are unused named as such for clarity.
Checklist