Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider attached collision objects in the ComputeFK service #2953

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

DaniGarciaLopez
Copy link
Contributor

Description

Currently, the ComputeFK service only works for robot links. By using getFrameTransform we can also consider attached collision objects and their subframes.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sjahr sjahr merged commit f30d51b into moveit:main Aug 7, 2024
10 of 12 checks passed
@manadaniel
Copy link

manadaniel commented Aug 14, 2024

@DaniGarciaLopez would you mind giving me a brief idea of what this added „consideration“ implies/improves for the average moveit2 user? Was not clever enough to get it from reading the code as I am unfortunately not familiar with the ComputeFK service. Thx!!

@DaniGarciaLopez
Copy link
Contributor Author

@DaniGarciaLopez would you mind giving me a brief idea of what this added „consideration“ implies/improves for the average moveit2 user? Was not clever enough to get it from reading the code as I am unfortunately not familiar with the ComputeFK service. Thx!!

The ComputeFK service allows you to calculate forward kinematics, which is the process of determining the Cartesian pose of a given frame from a set of joint positions. This is the opposite of inverse kinematics, where joint positions are determined based on a desired Cartesian pose. Previously, the service only worked with the robot links. With the changes introduced in this PR, you can now also compute the Cartesian pose of collision objects and their subframes if they are attached to the robot.

We mainly use this service for calibration purposes: we attach an object to the end effector of the robot, manually move the robot to a desired location, and then store the current Cartesian pose of the object to calibrate various frames.

Hope this helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants