Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove _ suffix from struct member variables #1689

Closed
sjahr opened this issue Nov 3, 2022 · 4 comments · Fixed by #1939
Closed

Remove _ suffix from struct member variables #1689

sjahr opened this issue Nov 3, 2022 · 4 comments · Fixed by #1939
Assignees
@AlexWebb03
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@sjahr
Copy link
Contributor

sjahr commented Nov 3, 2022

The _ suffix is a naming convention for private member variables of classes, not public struct members. Therefore, the _ suffix of members of MotionPlanResponse and MotionPlanDetailedResponse should be removed.
@sjahr sjahr added enhancement New feature or request good first issue Good for newcomers labels Nov 3, 2022
@sjahr sjahr mentioned this issue Nov 3, 2022
Merged
9 tasks
@JoaoVitorMenezesMagalhaes
Copy link

Hello @sjahr!! Can you assign me to this issue, please ?

Closed
6 tasks
@JoaoVitorMenezesMagalhaes
Copy link

I believe i have fixed it with my PR #1693

Closed
@AlexWebb03
Copy link
Contributor

Hiya, I'd like to work on this. Should I finish @JoaoVitorMenezesMagalhaes MR or open a new one?

@sjahr
Copy link
Contributor Author

sjahr commented Jan 31, 2023

@AlexWebb03 Great thank you!

Should I finish @JoaoVitorMenezesMagalhaes PR or open a new one?

Whatever you prefer 👍

@AlexWebb03 AlexWebb03 mentioned this issue Feb 9, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexWebb03 AlexWebb03

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove underscore from public member in MotionPlanResponse AlexWebb03/moveit2
3 participants
@sjahr @JoaoVitorMenezesMagalhaes @AlexWebb03