Fix nullable column type parsing by BigQuery connector #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a Parsons Table column has values like `[None, None, True, False]`, the BigQuery connector will infer that the appropriate type for this column is NoneType, which it will translate into a STRING type. This change ensures that types returned by petl.typecheck() will choose the first available type that isn't 'NoneType' if that is available.
|
Closing this in favor of consolidated fixes in #959 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a Parsons Table column has values like
[None, None, True, False],the BigQuery connector will infer that the appropriate type for this
column is NoneType, which it will translate into a STRING type.
This change ensures that types returned by petl.typecheck() will
choose the first available type that isnt
NoneTypeif that isavailable.
Adds a test that checks if the connector is able to successfully parse a column type when nulls are included. First commit here will allow test to run and fail, second commit will make the fix and demonstrate the test succeeds.