-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Action Network events endpoints #520
Comments
happy to submit a PR for this. Can you elaborate on what you mean by this?
|
Whoops-- that isn't super descriptive. :) See revised above. |
Our organization would love Action Network events endpoints! |
Still working on a PR for this, but I want to clean up the testing framework to be a little bit more versatile here (e.g. integrating pytest and factoryboy) so we can ideally knock out the rest of the API. It's already getting pretty busy. Are there any preferred architectures being used for this elsewhere in Parsons, or any reasons I might not be aware of to avoid doing this? Otherwise would like to nail this down within the next couple of weeks. |
Hi @schlich! Are you still planning to submit a PR? I know it's been ages and ages, so no worries if you're not. |
Yes, this is absolutely still on my radar! Thank you for the nudge. I've done a lot of work with the Action Network API since my last comment (and am a much more experienced tester) so I should be able to make quick work of it. |
Excellent news. :) Fyi we've got a contributor call tomorrow at 2pm ET, feel free to join us! lmk if you need join info. |
Hi @schlich, what's the status on this? Happy to pair on it if that's helpful. |
It's still on my radar, and I apologize for not following up/following through sooner. I got partway through a big refactoring before realizing I needed to break it up into smaller chunks. I'm also keeping eyes on a colleague developing a version of the api client published under the I would be very happy to pair on this if only to keep me accountable :) I still think we can make fairly quick work of it. |
No worries re: the delay. Life happens! I'll DM you my calendly on Slack - looking forward to pairing :) |
Believe this PR included this. #900 |
It does! Thanks for noticing @mkrausse-ggtx |
Currently Parsons doesn't include the events endpoints for Action Network.
This prevents us from specifying page size and page number and makes pulling down events complex and difficult to parse.By adding these, we could use a function similar to
get_people
to pull down events specifying the page number and page size as args. Right now we can accomplish that by invoking_get_page
, but not as its own function.The text was updated successfully, but these errors were encountered: