Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Action Network events endpoints #520

Closed
esnowrackley opened this issue May 5, 2021 · 12 comments
Closed

Add Action Network events endpoints #520

esnowrackley opened this issue May 5, 2021 · 12 comments
Assignees
Labels
connector update Work type - additions or changes to the functions of an existing Parsons connector enhancement Impact - something should be added to or changed about Parsons that isn't causing a current breakage good first issue These issues are great ones to start working on for Parsons newcomers! medium priority Priority - this doesn't need to be addressed immediately, but will broadly impact Parsons users

Comments

@esnowrackley
Copy link

esnowrackley commented May 5, 2021

Currently Parsons doesn't include the events endpoints for Action Network. This prevents us from specifying page size and page number and makes pulling down events complex and difficult to parse.

By adding these, we could use a function similar to get_people to pull down events specifying the page number and page size as args. Right now we can accomplish that by invoking _get_page, but not as its own function.

@esnowrackley esnowrackley changed the title Action Network events endpoints Add Action Network events endpoints May 5, 2021
@schlich
Copy link
Contributor

schlich commented May 5, 2021

happy to submit a PR for this. Can you elaborate on what you mean by this?

This prevents us from specifying page size and page number

@esnowrackley
Copy link
Author

Whoops-- that isn't super descriptive. :) See revised above.

@stevans
Copy link

stevans commented Jun 4, 2021

Our organization would love Action Network events endpoints!

@schlich
Copy link
Contributor

schlich commented Jun 15, 2021

Still working on a PR for this, but I want to clean up the testing framework to be a little bit more versatile here (e.g. integrating pytest and factoryboy) so we can ideally knock out the rest of the API. It's already getting pretty busy. Are there any preferred architectures being used for this elsewhere in Parsons, or any reasons I might not be aware of to avoid doing this? Otherwise would like to nail this down within the next couple of weeks.

@neverett neverett added the connector update Work type - additions or changes to the functions of an existing Parsons connector label Nov 3, 2021
@SorenSpicknall SorenSpicknall added enhancement Impact - something should be added to or changed about Parsons that isn't causing a current breakage good first issue These issues are great ones to start working on for Parsons newcomers! labels Mar 17, 2022
@shaunagm
Copy link
Collaborator

Hi @schlich! Are you still planning to submit a PR? I know it's been ages and ages, so no worries if you're not.

@schlich
Copy link
Contributor

schlich commented Aug 24, 2022

Hi @schlich! Are you still planning to submit a PR? I know it's been ages and ages, so no worries if you're not.

Yes, this is absolutely still on my radar! Thank you for the nudge. I've done a lot of work with the Action Network API since my last comment (and am a much more experienced tester) so I should be able to make quick work of it.

@shaunagm
Copy link
Collaborator

Excellent news. :)

Fyi we've got a contributor call tomorrow at 2pm ET, feel free to join us! lmk if you need join info.

@shaunagm
Copy link
Collaborator

Hi @schlich, what's the status on this? Happy to pair on it if that's helpful.

@shaunagm shaunagm assigned shaunagm and schlich and unassigned shaunagm Feb 21, 2023
@shaunagm shaunagm added the medium priority Priority - this doesn't need to be addressed immediately, but will broadly impact Parsons users label Feb 21, 2023
@schlich
Copy link
Contributor

schlich commented Feb 21, 2023

It's still on my radar, and I apologize for not following up/following through sooner. I got partway through a big refactoring before realizing I needed to break it up into smaller chunks. I'm also keeping eyes on a colleague developing a version of the api client published under the osdi package (pretty primitive still, just wanna make sure we don't duplicate work).

I would be very happy to pair on this if only to keep me accountable :) I still think we can make fairly quick work of it.

@shaunagm
Copy link
Collaborator

No worries re: the delay. Life happens! I'll DM you my calendly on Slack - looking forward to pairing :)

@mkrausse-ggtx
Copy link
Contributor

Believe this PR included this. #900

@shaunagm
Copy link
Collaborator

It does! Thanks for noticing @mkrausse-ggtx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connector update Work type - additions or changes to the functions of an existing Parsons connector enhancement Impact - something should be added to or changed about Parsons that isn't causing a current breakage good first issue These issues are great ones to start working on for Parsons newcomers! medium priority Priority - this doesn't need to be addressed immediately, but will broadly impact Parsons users
Projects
None yet
Development

No branches or pull requests

7 participants