Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

up down esc enter should behave like native #68

Open
mousemke opened this issue Apr 8, 2016 · 3 comments
Open

up down esc enter should behave like native #68

mousemke opened this issue Apr 8, 2016 · 3 comments

Comments

@mousemke
Copy link
Owner

mousemke commented Apr 8, 2016

up and down should not change selection, instead they should behave move like hover

enter should select the currently "hovered" item

esc should close the flounder, leaving the previous value selected

@mousemke mousemke added this to the 0.6.4 milestone Apr 8, 2016
@mousemke
Copy link
Owner Author

so. we need to define native. the behavior above is from chrome and correct. but there's 2 major issues with it

  1. we would need to build an extra selection layer between the selected and events. While not impossible by any means, this is quite a project.

  2. we only looked at chrome. firefox presents all sort of other issues. in firefox, the current behavior is native. and to make that even more of an issue, the native firefox behavior cannot be prevented. (we've run into this issue before in incrementing up/down)

if we cant prevent FF from it's native in this case, I suggest we bring chrome in line with ff behavior (which it already was). Suggest abandoning this issue as it make anything we make in ff extremely hacky.

this being closed does leave one large question: when and how often do we fire onSelect? It almost has to fall back to w/ include each up/down keypress. The only other idea i have is possibly a debounce so it only gets fired every X ms, but that seems a bit hacky too

@kristina-kurshakova-sociomantic

@kristina-kurshakova-sociomantic
Copy link
Contributor

  1. In case of different behaviour of different browsers I wouldn't rely on native dropdown. All browsers should show the same behaviour.

One more point against select on navigate: in multiselect that behaviour gives weird effect.

@mousemke
Copy link
Owner Author

they should all show the same behavior. there are multiple options; there is only one behavior that works the same in all browsers (that would be the current/firefox) behavior.

@kristina-kurshakova-sociomantic arrows may actually be disabled in most multiselect instances

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants