Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storm-like helpers #151

Merged
merged 17 commits into from
Jul 7, 2016
Merged

Add storm-like helpers #151

merged 17 commits into from
Jul 7, 2016

Conversation

moul
Copy link
Owner

@moul moul commented Jul 5, 2016

No description provided.

return list
}

func (ol *OptionsList) Remove(key string) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported method OptionsList.Remove should have comment or be unexported

@@ -519,10 +525,10 @@ func New() *Config {
return &config
}

// Open returns a Config object loaded with standard configuration file paths
func Open() (*Config, error) {
// OpenPath parses a configuration file and returns a *Config object
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment on exported function Open should be of the form "Open ..."

Value string
}

// OptionList is a list of options
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment on exported type OptionsList should be of the form "OptionsList ..." (with optional leading article)

@moul moul merged commit 052d3ab into master Jul 7, 2016
@moul moul removed the in progress label Jul 7, 2016
@moul moul deleted the storm-like-helpers branch July 7, 2016 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants