Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adhere to padded-blocks #85

Merged
merged 2 commits into from
Aug 17, 2015
Merged

adhere to padded-blocks #85

merged 2 commits into from
Aug 17, 2015

Conversation

LinusU
Copy link
Contributor

@LinusU LinusU commented Aug 14, 2015

We are in the process of adding back the rule padded-blocks into standard. It was temporarily disabled because of a bug in eslint which now has been fixed.

This pull request makes sure that your coding style is compliant with the new version.

Please see standard/standard#170 for more info.

@maxbeatty
Copy link
Contributor

Thanks for taking this initiative, @LinusU! We're currently using standard@2 and it looks like the current major version is 5

$ npm info standard | grep version:
  version: '5.1.0',

Will this change to padded-blocks be a major version bump? If so, perhaps this PR should include updating the dep version when it's ready

@LinusU
Copy link
Contributor Author

LinusU commented Aug 17, 2015

No problem 🚀

The plan is to release it as a minor version, most probably 5.2. I'll bump it to ^5.1.0, that's what I tested against (+ plus the padding rule). Sounds good?

@LinusU
Copy link
Contributor Author

LinusU commented Aug 17, 2015

Should be good to go 👍

maxbeatty added a commit that referenced this pull request Aug 17, 2015
@maxbeatty maxbeatty merged commit cc6a7f4 into motdotla:master Aug 17, 2015
@LinusU LinusU deleted the standard-style branch August 17, 2015 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants