[MOSIP-32460]Migration to develop from develop-java21 #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JanardhanBS-SyncByte <[email protected]>
Neha2365
approved these changes
Jul 19, 2024
| <dependency> | ||
| <groupId>io.mosip.authentication</groupId> | ||
| <artifactId>authentication-core</artifactId> | ||
| <version>${authentication-core.version}</version> | ||
| <version>${authentication.core.version}</version> | ||
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
Why Kernel-core is added as dependency? kernel-bom will include the kernel-core. please remove all the dependency which are getting added thru bom.
There was a problem hiding this comment.
Is this file deleted? if yes why it is deleted?
| <groupId>org.projectlombok</groupId> | ||
| <artifactId>lombok</artifactId> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| <!-- Kernel Core --> | ||
| <dependency> | ||
| <groupId>io.mosip.kernel</groupId> |
There was a problem hiding this comment.
remove the kernel-core dependency.
| @@ -217,7 +35,7 @@ | |||
| <dependency> | |||
There was a problem hiding this comment.
remove kernel-core dependency. Remove other dependencies as well which are getting added thru bom
| @@ -73,34 +88,17 @@ | |||
| <dependency> | |||
There was a problem hiding this comment.
Remove this dependency, because it will get included thru bom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.