Fix flash attention GQA bug to use the dynamic size of the key/value tensors - used for eval/inference #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue shows up w/ flash attention during inference or if running icl tasks, the
.view()causes a runtime error due to the wrong size ofkey_unpadandvalue_unpad. Ty to @ShashankMosaicML for flagging!Example:
RuntimeError: shape '[2, 1024, 5, -1]' is invalid for input of size 192000Tested with 3b models to have same loss with the fix and without:
Eval only works for the fix: