Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HF local module copy contention with a meta init on local rank 0 #710

Merged
merged 7 commits into from
Nov 2, 2023
Merged

Fix HF local module copy contention with a meta init on local rank 0 #710

merged 7 commits into from
Nov 2, 2023

Conversation

dakinggg
Copy link
Collaborator

@dakinggg dakinggg commented Nov 2, 2023 •
edited
Loading

Tested on the workload that failed, and it successfully made it through checkpoint loading and into eval 7/7 times.

@dakinggg dakinggg changed the title Dummy init Fix HF local module copy contention with a meta init on local rank 0 Nov 2, 2023
@dakinggg dakinggg marked this pull request as ready for review November 2, 2023 15:44
irenedea
irenedea approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@irenedea irenedea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this fix!

llmfoundry/models/hf/hf_causal_lm.py Show resolved Hide resolved
@mosaicml mosaicml deleted a comment from j316chuck Nov 2, 2023
j316chuck
j316chuck approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@j316chuck j316chuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dakinggg dakinggg merged commit 6c41241 into mosaicml:main Nov 2, 2023
12 checks passed
@dakinggg dakinggg deleted the dummy-init branch December 11, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irenedea irenedea irenedea approved these changes

@j316chuck j316chuck j316chuck approved these changes

@mvpatel2000 mvpatel2000 Awaiting requested review from mvpatel2000

@XiaohanZhangCMU XiaohanZhangCMU Awaiting requested review from XiaohanZhangCMU

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dakinggg @j316chuck @irenedea