Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test coverage for lion and lion8b checkpoint interop #679

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Add test coverage for lion and lion8b checkpoint interop #679

merged 3 commits into from
Oct 31, 2023

Conversation

dblalock
Copy link
Contributor

Makes sure that we can switch between DecoupledLionW and DecoupledLionW_8bit seamlessly. Just touches test_lion8b.py.

@dblalock dblalock marked this pull request as ready for review October 18, 2023 02:54
@dblalock dblalock requested a review from mvpatel2000 October 18, 2023 02:54
mvpatel2000
mvpatel2000 approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine to ignore the dealloc thing.

Thanks for adding this!

@dakinggg dakinggg enabled auto-merge (squash) October 31, 2023 05:40
@dakinggg dakinggg merged commit 08f377b into main Oct 31, 2023
12 checks passed
@dakinggg dakinggg deleted the davis/lion8b-checkpoint-interop branch November 17, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dblalock @mvpatel2000 @dakinggg