Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checkpoint events #3468

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Fix checkpoint events #3468

merged 1 commit into from
Jul 15, 2024

Conversation

b-chu
Copy link
Contributor

@b-chu b-chu commented Jul 10, 2024 •
edited
Loading

What does this PR do?

Move checkpoint event to emit a run event when the symlink is uploaded. This means that the run event will accurately track when a checkpoint upload finishes.

A previous approximation was merged in #3316

e2e test checkpoint-events-test-rd9zih

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@b-chu b-chu requested a review from a team as a code owner July 10, 2024 21:11
bigning
bigning approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@bigning bigning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for the change! could you add an e2e test?

@b-chu b-chu enabled auto-merge (squash) July 15, 2024 14:21
@b-chu b-chu merged commit 922bc18 into dev Jul 15, 2024
14 checks passed
@b-chu b-chu deleted the events branch July 15, 2024 14:27
mvpatel2000 pushed a commit to mvpatel2000/composer that referenced this pull request Jul 21, 2024
@b-chu @mvpatel2000
Fix checkpoint events (mosaicml#3468)
f574e25
mvpatel2000 pushed a commit that referenced this pull request Jul 21, 2024
@b-chu @mvpatel2000
Fix checkpoint events (#3468)
a5dc155
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigning bigning bigning approved these changes

@sakshigupta93 sakshigupta93 Awaiting requested review from sakshigupta93

@eracah eracah Awaiting requested review from eracah

@jjanezhang jjanezhang Awaiting requested review from jjanezhang

@waiwuc waiwuc Awaiting requested review from waiwuc

@ethanma-db ethanma-db Awaiting requested review from ethanma-db

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@b-chu @bigning