New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test edge case #12

Closed

MathisGD opened this issue Feb 16, 2024 · 1 comment

Contributor

MathisGD commented Feb 16, 2024

          If `allocations[i].assets` is exactly 0 after this line, then metamorpho triggers a special case by withdrawing with shares. I think it works out in the end because Morpho.withdraw will do the exact same computation, but I would rest easier if there was a test for it. So the test would pass an amount to withdraw that is equal to the expected supply assets of the vault

Originally posted by @QGarchery in #5 (comment)

The text was updated successfully, but these errors were encountered:

MathisGD mentioned this issue

Reallocate by withdrawals + sink #5

Merged

1 task

Contributor Author

MathisGD commented Feb 29, 2024

Discussed here: https://github.com/cantinasec/review-morpho/pull/4/files#r1502685974

imo not worth a test

MathisGD closed this as not planned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment