Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raise PR later: fs.zipfs won't close properly #310

Closed
chfw opened this issue Jul 31, 2019 · 2 comments
Closed

raise PR later: fs.zipfs won't close properly #310

chfw opened this issue Jul 31, 2019 · 2 comments

Comments

@chfw
Copy link
Member

chfw commented Jul 31, 2019 

import fs
fs.open_fs('zip://I_do_not_exist_.zip')

Exception ignored in: <function FS.del at 0x10491cd08>
Traceback (most recent call last):
File "/Users/jaska/github/moremoban/moban-env/lib/python3.7/site-packages/fs/base.py", line 117, in del
self.close()
File "/Users/jaska/github/moremoban/moban-env/lib/python3.7/site-packages/fs/zipfs.py", line 437, in close
self._zip.close()
AttributeError: 'xxx' object has no attribute '_zip'
@chfw
Copy link
Member Author

chfw commented Aug 16, 2019

PyFilesystem/pyfilesystem2#333

@chfw chfw closed this as completed Aug 16, 2019
@chfw
Copy link
Member Author

chfw commented Aug 16, 2019

PyFilesystem/pyfilesystem2#330

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chfw