Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome loading conflict - beforeLoadHook #22

Open
Geek4AllSeasons opened this issue Jun 18, 2010 · 1 comment
Open

Chrome loading conflict - beforeLoadHook #22

Geek4AllSeasons opened this issue Jun 18, 2010 · 1 comment

Comments

@Geek4AllSeasons
Copy link

I found a kludge work-around that allows Keysnail to load completely.

  1. Clear XUL cache (used Addon Developer Helper Restart Application).
  2. Start Firefox. Keysnail doesn't work.
  3. Open new window, Keysnail works.

I haven't studied the code yet, so I may be hallucinating. The underlying problem appears to be a race condition that breaks call back notification and/or loadOverlay queue dispatching for boundary use cases.

The keysnail.js load message is displayed at the end of chrome initialization. Keysnail has loaded completely when startup processing/timing has varied.

Clearing/reinitializing the XUL cache corrected a problem with AIOS toolbar initialization on windows opened after startup. Reopening window 1, using Addon Developer Helper, allowed Keysnail to load several times. An uncontrolled chrome change caused subsequent attempts to reopen a window to fail with Firefox entering a tight infinite loop.

It is reasonable to speculate adjusting load timing through a hook executed early in the loadOverlay process would avoid conflicts with other extensions. There may be other uses for loadOverlay hooks.

@mooz
Copy link
Owner

mooz commented Jun 19, 2010

For fundamental reason, I can't arrange the hook point functions added to it will be executed early in the loadOverlay process.

I've removed the loadOverlay from keysnail-loader and use mozIJSSubScriptLoader alternatively.

The package (keysnail-1.6.2b) is in the Downloads. Try this version and tell me whether it works correctly or not.

http://github.com/mooz/keysnail/downloads

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants