Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HoK: misaligned hints in webpage with responsive CSS design #210

Open
caikechao opened this issue Aug 2, 2016 · 4 comments
Open

HoK: misaligned hints in webpage with responsive CSS design #210

caikechao opened this issue Aug 2, 2016 · 4 comments

Comments

@caikechao
Copy link

caikechao commented Aug 2, 2016

For example, in this webpage [ http://jblevins.org/ ], when I run hok-start-foreground-mode, I get misaligned hints as shown in the following figure:

selection_065

Maybe the responsive CSS design changed the location of the hints. But vimperator does not have this problem.

Could you give me some advice to fix such misaligned hint?

Update:

I am able to pin point the problem to the function getBodyOffsets in the file hok.ks.js in https://github.com/mooz/keysnail/blob/master/plugins/hok.ks.js#L833

I am still trying to get familiar with JavaScript and also trying to learn debugging the Keysnail plugin ... Are there any materials or wiki pages for the newbies like me to get involved in the Keysnail development?

Thank you in advance!

@caikechao
Copy link
Author

Another site that causes misaligned hints of HoK in keysnail ...

https://www.r-bloggers.com/

selection_066

@caikechao
Copy link
Author

I just wrote a dirty fix (#212) to fix the problem. Now the hints and the elements are aligned.

selection_068

selection_067

@pierrelegall
Copy link

I patched my hok.ks.js with your quick fix. It works for me too.

Another web site where we can reproduce it: https://linuxfr.org/

@caikechao
Copy link
Author

@lepieru Thanks for testing the fix. Actually, I think my fix is "dirty" as I don't know how the function getBodyOffsets in Hok.ks.js works ... I am hoping the developers or other contributors can help write a clean and elegant fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants