Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSR php Extension, currently no tests on Windows #238

Closed
adrolli opened this issue Dec 6, 2023 · 1 comment
Closed

PSR php Extension, currently no tests on Windows #238

adrolli opened this issue Dec 6, 2023 · 1 comment
Labels
waiting This issue needs to wait

Comments

@adrolli
Copy link
Member

adrolli commented Dec 6, 2023

Currently changed:

  matrix:
    os: [ubuntu-latest, windows-latest]

instead of https://github.com/mooxphp/moox/blob/e3f120155349acfae2a1f376d70a932c2a8bf3b2/.github/workflows/pest.yml#L22C1-L23C28

because of laravel/framework#46165 and me being too lazy to split the non-existing tests for Windows.

and this does not play well with windows

  - name: Remove PHP-PSR Extension
    run: |
      sudo apt remove php8.2-psr

Removing PSR ext is also done in codacy, code climate, and phpstan.

Probably resolved with Laravel 11.

@adrolli adrolli added the waiting This issue needs to wait label Dec 6, 2023
@adrolli adrolli added this to Monorepo Dec 6, 2023
@adrolli
Copy link
Member Author

adrolli commented Mar 25, 2024

PSR extension works with Laravel 11, but Windows runner does not support the MySQL container, so we continue to only test on Ubuntu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting This issue needs to wait
Projects
Status: Done
Development

No branches or pull requests

1 participant