prenote file created with autogenerated ADV service class code

[adamdecaf]

ACH Version: v1.18.4

What were you trying to do?
From Zach,

Another one here maybe - I just created a Prenote file and ended up with "serviceClassCode": 280, in the ADV Batch control section - mid you I did not make this section so this was completely generated by Moov ACH (edited)

From Connor,

pretty sure that documentation is incorrect. 280 is a service class code specifically for ADV batches

What did you expect to see?
File created with the proper ServiceClassCodes and without errors.

[ckbaum]

From the NACHA Operating Rules:

The Service Class Code (BAI Specifications) identifies the general
classification of dollar Entries to be exchanged. ACH Entries are
assigned Service Class Code series 200-299.

Code Values:

200 ACH Entries Mixed Debits and Credits

220 ACH Credits Only

225 ACH Debits Only

280 ACH Automated Accounting Advices

This leads me to think any ADV batch should have a 280 Service Class Code, though as usual the rulebook is not extremely clear about this 😅.

[adamdecaf]

@zbruhnke do you have more details here? What did you expect to see?

[zbruhnke]

I've got the NACHA guidelines, I'll find the answer, give me just a bit

[zbruhnke]

@adamdecaf https://go.hmb.la/UGJlYi

Looks like 280 is correct if it's considered an ADV but I'm with you, I don't know that it is

[zbruhnke]

AFAICT Prenotes should work as 200 225 OR 220 but NOT 280

It says they can be mixed into regular transaction batches with several SEC codes

[adamdecaf]

@zbruhnke so the issue here is that prenote files validate without errors when they have a 280 in there somewhere?

[ChillOrb]

Hi @adamdecaf and team,

I'm interested in contributing to fixing this issue related to the autogenerated ADV service class code in Prenote files. Before I start working on this, I have a few clarifying questions:

1. Could you provide more details on how the service class code 280 is being autogenerated in Prenote files? Is this behavior consistent across different scenarios?

2. What is the expected behavior for Prenote files in terms of the Service Class Codes? Should it strictly follow the codes 200, 225, or 220 as per the NACHA guidelines?

I came across this code in the batchADV.go file. Does this code already address the issue, or is there something else that needs to be modified?

I appreciate any insights you can provide, and I look forward to collaborating on resolving this issue.

Best,

[adamdecaf]

280 is the ADV SCC code, but I'm not sure if prenotes can use that. The rule docs were unclear in previous releases of the Nacha rules. I think we need to ask Nacha if you can have a batch with ADV entries and prenotes, or if that's an invalid combination.

https://github.com/moov-io/ach/blob/master/batchHeader.go#L136