Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cancelling JSON import in the middle gives an error #1205

Open
NicolasAnquetil opened this issue Oct 20, 2024 · 2 comments
Open

cancelling JSON import in the middle gives an error #1205

NicolasAnquetil opened this issue Oct 20, 2024 · 2 comments
Labels

Comments

@NicolasAnquetil
Copy link
Contributor

  • Start an import of a mooseModel from a file (eg. a Java model from a JSON file)
  • interrupt it in the middle by clicking on the red button in the progrtess bar
  • gives some error (depending on where it was in the import)

The interruption should be catched

@Gabriel-Darbord
Copy link
Member

I tried it but it does not actually throw an error, it opens a debugger on the halted process.
This could arguably be useful, but I guess the expected behavior is that the process should stop quietly (maybe with a toast saying it was interrupted).

@Gabriel-Darbord
Copy link
Member

Gabriel-Darbord commented Nov 29, 2024

Actually more complicated than anticipated because no exception is thrown and the behavior is hard-coded in the Job class.
This issue depends on pharo-project/pharo#17471 (unless we want to go at it another way).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants