Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename relationship between TParametricEntity and TConcretisation #706

Closed
Gabriel-Darbord opened this issue Jan 31, 2024 · 2 comments
Closed

Comments

@Gabriel-Darbord
Copy link
Member

Gabriel-Darbord commented Jan 31, 2024

Each ParametricEntity can be related to another one by a Concretisation association, where one is more generic and the other is more concrete.
The name of the relation of the more generic entity to the association is concretisation, which is fitting.
However, the name of the opposite relation is genericEntity, which I think is misleading.
Especially since the relation from the association to the more generic entity is already called genericEntity, where it makes sense.
This would lead to code as follows:

parametricEntity genericEntity "<- Concretisation" genericEntity "<- ParametricEntity"

I suggest to rename the opposite relation of concretisation, from genericEntity to genericization (a real word).

concreteEntity genericization "<- Concretisation" genericEntity "<- ParametricEntity"
@NicolasAnquetil
Copy link
Contributor

I am not sure genericEntity is a good name for the relation because it is not really an Entity
May be this is the one we should rename (or may be both)

@Gabriel-Darbord
Copy link
Member Author

Gabriel-Darbord commented Jan 31, 2024

I think we agree, but the wording of "opposite relation" was poorly chosen.
I'm referring to the opposite of concreteEntity, which is called genericEntitities in the diagram, and genericEntity in the current implementation.
image

The renaming allows us to write instead of the previous example:

concreteEntity genericization "<- Concretisation" genericEntity "<- ParametricEntity"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants