Skip to content
This repository has been archived by the owner on Jul 11, 2019. It is now read-only.

bug: unverified users get a borked avatar #104

Closed
Trott opened this issue May 1, 2015 · 0 comments
Closed

bug: unverified users get a borked avatar #104

Trott opened this issue May 1, 2015 · 0 comments
Labels

Comments

@Trott
Copy link
Contributor

Trott commented May 1, 2015

rich-message.js uses this to calculate the avatar URL in some cases:

'https://github.com/' + message.username + '.png'

However, message.username is intentionally mangled in some cases by friends to be Allegedly so-and-so rather than so-and-so and in those cases, the avatar URL will be wrong and will typically result in a 404.

Would the solution be to use the unmangled username even though the person isn't verified? Or the cat image? Or a new image that is a big question mark or something to show that you can't be sure it's the person it says it is?

@Trott Trott changed the title bug: anonymous users get a borked avatar bug: unverified users get a borked avatar May 1, 2015
@Flet Flet added the bug label May 7, 2015
@Trott Trott closed this as completed Sep 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants