Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to build but make error "No rule to make target" #402

Closed
ghost opened this issue Feb 11, 2018 · 7 comments
Closed

Try to build but make error "No rule to make target" #402

ghost opened this issue Feb 11, 2018 · 7 comments

Comments

@ghost
Copy link

ghost commented Feb 11, 2018

Hello,

I'm trying to build myself the CRX because I need some special resolutions like 1440p at 16/9 for an iMac and 1600p at 16/10 for a macbook pro retina.
So I folk and modify the index.html.
I follow this tuto : https://github.com/Jorys-Paulin/moonlight-chrome/wiki/Building

But as you can see on the picture, I god a trouble at make.bat with a "No rule to make target" "needed by" ...
capture d ecran 2018-02-11 a 16 44 18
So how can I avoid this error ?

@jorys-paulin
Copy link
Collaborator

jorys-paulin commented Feb 11, 2018

You need to init git submodules, I forgot to add this in my guide

@ghost
Copy link
Author

ghost commented Feb 11, 2018

@jorys-paulin thank's for your reply and it's now working like a charm !

Indeed, I had to things 2 do :

  • copy, in the moonlight folder, the .git folder that I found from the branch build (I don't know why it wasn't there in my folk)
  • inside moonlight-chrome folder, run in the cmd : git submodule update --init --recursive

If you can Edit your tutorial it'll be great for newer people because it's almost perfect ;-)

PS : so my build work, I added some new resolutions, like 1440p, and there working perfectly.

@KayZey
Copy link

KayZey commented Feb 12, 2018

Cool, can you make a few 21:9 ratios or isn't that supported?

@ghost
Copy link
Author

ghost commented Feb 12, 2018

@KayZey Yes I can, please tell me precisely what resolutions do you want ?
I cannot test myself 21:9 with a native screen in server (I can "trick" by adding new resolutions in Nvidia panel) and client, but the quality won't be good to see (I could only testing bitrate), so I'll modify my fork, build it and send it to you for testing.
I'll try this toning or tomorrow.

Please reply to me directly into #386 because the issue 402 is solved ;-)

@jorys-paulin
Copy link
Collaborator

Hey @waumand, you can close this issue now, I'll add this to my guide :)

@KayZey
Copy link

KayZey commented Feb 13, 2018

I have a LG Ultra wide that runs at 2560x1080. Would be awesome if you could build one for me. I also have a Macbook that runs at 1440p, but it didn't seem to work all that well your client. Do I have to run something special on the Nvidia Machine?

@ghost
Copy link
Author

ghost commented Feb 14, 2018

@KayZey come on in #386 because I close this Issue.
I've done what you need, it's build there, check it.

I don't have do something special in my Nvidia Machine, except I also create these resolutions on my Nvidia panel (because my TV didn't support more than FullHD 16:9) and check the support for resolutions that my TV didn't support.
What is your graphic card in your Nvidia Machine ? You are in RJ45 ?
What is the model of your Macbook ? And you already are in Wifi AC I suppose ? (needed, working not great in Wifi N)

@ghost ghost closed this as completed Feb 14, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants