new package Encoding
#1236
Draft
new package Encoding
#1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3948Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
ping @Yoorkin. |
This was referenced Nov 25, 2024
Yoorkin
reviewed
Nov 25, 2024
buffer/buffer.mbt
Outdated
| pub fn to_unchecked_string( | ||
| self : T, | ||
| offset~ : Int = 0, | ||
| length~ : Int = self.len |
There was a problem hiding this comment.
We may need to avoid labelled dependency: #1231 (comment)
Yoorkin
reviewed
Nov 27, 2024
| let bs0 = @buffer.new(size_hint=2) | ||
| let (j0, j1) = if be { (0, 1) } else { (1, 0) } | ||
| bs0[j0] = (hi >> 8).to_byte() | ||
| bs0[j1] = hi.land(0xFF).to_byte() |
There was a problem hiding this comment.
Use bs0.write_byte() instead of random access? The op_set method for buffer is weird
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
UTF16BEStream{Lossy, Strict}Charsfrom_{bytes, array}apidecode_strictto error-raisable function instead of justabort.usage
see
encoding/encoding_test.mbt.api
see
encoding/encoding.mbti.