Downgrade ed25519 #1998
Merged
Downgrade ed25519 #1998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
girazoki
added
D3-trivial
crystalin
approved these changes
Dec 12, 2022
tgmichel
approved these changes
Dec 12, 2022
What happened with 1.5.2? |
|
Okay ty! @girazoki any idea why the signature was parsed as invalid? |
|
@bkchr the signature hits this line https://github.com/dalek-cryptography/curve25519-dalek/blob/06186b8511722fcf5341f67ee48c4c448c373313/src/scalar.rs#L261 and it yields invalid. The thing is that en ed25519 prior to 1.3.0 it does not hit a panick, but after 1.3.0 hits this panick |
|
Thank you @bkchr |
imstar15
pushed a commit
to AvaProtocol/moonbeam
that referenced
this pull request
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Downgrades dalek library function to make it compatible with the host function
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?