Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aligns GasWeightMapping with Substrate do_pre_dispatch logic #1884

Merged
merged 8 commits into from
Oct 20, 2022
Merged

Aligns GasWeightMapping with Substrate do_pre_dispatch logic #1884

merged 8 commits into from
Oct 20, 2022

Conversation

tgmichel
Copy link
Contributor

What does it do?

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@tgmichel tgmichel added A0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Oct 20, 2022
@crystalin crystalin marked this pull request as ready for review October 20, 2022 14:29
@crystalin crystalin merged commit 5b9078e into master Oct 20, 2022
@crystalin crystalin deleted the tgm-frontier-865 branch October 20, 2022 17:42
@crystalin crystalin changed the title Align GasWeightMapping with Substrate do_pre_dispatch logic Aligns GasWeightMapping with Substrate do_pre_dispatch logic Oct 20, 2022
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Jan 11, 2023
@librelois librelois mentioned this pull request Jan 23, 2023
Closed
imstar15 pushed a commit to AvaProtocol/moonbeam that referenced this pull request May 16, 2023
@tgmichel @notlesh @imstar15
Align GasWeightMapping with Substrate do_pre_dispatch logic (moon…
b083629 
…beam-foundation#1884)

* Align `GasWeightMapping` with Substrate `do_pre_dispatch` logic

* Fix tests attempt 1

* Fix tests attempt 2

* Fix ts tests attempt 1

* Remove consolelog

* Increase gas limit in test to account for extra weight headroom

* Fix test

* prettier

Co-authored-by: notlesh <[email protected]>
Co-authored-by: Crystalin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@librelois librelois librelois approved these changes

@notlesh notlesh notlesh approved these changes

Assignees
No one assigned
Labels
A0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tgmichel @notlesh @librelois @crystalin