Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the unused and problematic tools #2873

Merged
merged 2 commits into from
May 28, 2024
Merged

Conversation

mattleibow
Copy link
Contributor

Description of Change

The Go modules are all far out of date and some tooling is reporting the repo as having security issues. We do not use any part of Go, EMSDK or perfetto in the SkiaSharp project.

In an ideal world we don't have to make changes and there is a special flag that exists for us to "disable all issues", but that does not exist and trying to make that flag work only on CI is unnecessary. We can just delete the few places that are having issues.

The Go modules are all far out of date and some tooling is reporting the
repo as having security issues. We do not use any part of Go, EMSDK or
perfetto in the SkiaSharp project.

In an ideal world we don't have to make changes and there is a special
flag that exists for us to "disable all issues", but that does not exist
and trying to make that flag work only on CI is unnecessary. We can just
delete the few places that are having issues.
@mattleibow mattleibow force-pushed the dev/disable-problems branch from abead00 to 6aa8f9b Compare May 28, 2024 16:33
@mattleibow mattleibow marked this pull request as ready for review May 28, 2024 19:35
@mattleibow mattleibow merged commit b6e477b into main May 28, 2024
1 of 2 checks passed
@mattleibow mattleibow deleted the dev/disable-problems branch May 28, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant