Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update skia to m116 #2829

Merged
merged 4 commits into from
Apr 15, 2024
Merged

Update skia to m116 #2829

merged 4 commits into from
Apr 15, 2024

Conversation

mattleibow
Copy link
Contributor

@mattleibow mattleibow commented Apr 11, 2024

Description of Change

The numbers are so close and the API is almost identical. I do see a missing API so we might as well lose it for now since we are breaking and we then have to break less in the next version.

API Changes

Removed:

  • SKImageFilter.CreateAlphaThreshold
    The image filter SKImageFilter.CreateAlphaThreshold is no longer implemented in native skia and has been removed.
    According to Google:

    SkImageFilters::AlphaThreshold has been removed. Its only use was in ChromeOS and that usage has been replaced with a Blend(kSrcIn, input, Picture(region)) filter graph to achieve the same effect.

    There does not seem to be an equivalent replacement, but also I have not seen any usages of it.

Behavioral Changes

None.

Required skia PR

mono/skia#122

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Merged related skia PRs
  • Changes adhere to coding standard
  • Updated documentation

@mattleibow mattleibow marked this pull request as draft April 11, 2024 21:45
@mattleibow mattleibow marked this pull request as ready for review April 12, 2024 00:56
@mattleibow
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@mattleibow mattleibow merged commit a0f3767 into main Apr 15, 2024
1 of 2 checks passed
@mattleibow mattleibow deleted the dev/update branch April 15, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant