Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose a generic, writable span for the pixels #1242

Merged
merged 2 commits into from
Apr 23, 2020
Merged

Expose a generic, writable span for the pixels #1242

merged 2 commits into from
Apr 23, 2020

Conversation

mattleibow
Copy link
Contributor

@mattleibow mattleibow commented Apr 19, 2020 •
edited
Loading

Description of Change

Expose a generic, writable span for the pixels. Also "cache" the info object in size so we don' have to hop the interop.

Bugs Fixed

API Changes

class SKPixmap {
    public unsafe Span<T> GetPixelSpan<T> () where T : unmanaged;
}

Behavioral Changes

None.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Updated documentation

@mattleibow
Expose a generic, writable span for the pixels
ff8ca2e 
Fixes #1240
Also "cache" the info object in size so we don' have to hop the interop.
@mattleibow mattleibow mentioned this pull request Apr 19, 2020
Closed
ziriax
ziriax previously approved these changes Apr 19, 2020
View reviewed changes
Copy link
Contributor

@ziriax ziriax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems perfect at first sight :)

@mattleibow mattleibow merged commit 290b61e into master Apr 23, 2020
@mattleibow mattleibow deleted the dev/fix-1240 branch April 23, 2020 00:02
@mattleibow mattleibow added this to the v1.68.2 milestone Apr 29, 2020
@antonfirsov antonfirsov mentioned this pull request Aug 9, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziriax ziriax ziriax left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.68.2
Development

Successfully merging this pull request may close these issues.

[QUESTION] Is SKPixMap.GetPixelSpan supposed to be readonly?
2 participants
@mattleibow @ziriax