Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CYBERSECURITY] libjpeg-turbo current version 2.1.3 in SkiaSharp #2578

Closed
1 task done
RChrisCoble opened this issue Aug 22, 2023 · 5 comments · Fixed by #2583
Closed
1 task done

[CYBERSECURITY] libjpeg-turbo current version 2.1.3 in SkiaSharp #2578

RChrisCoble opened this issue Aug 22, 2023 · 5 comments · Fixed by #2583
Labels
Milestone

Comments

@RChrisCoble
Copy link

Description

Hello @mattleibow, as you're updating some references do you plan on updating the following vulnerability as well?

Libjpeg turbo current version 2.1.3 in SkiaSharp

https://github.com/mono/skia/blob/0c511b3c833e441cb9edd6be1d13d2b3dd20c6b8/DEPS

CVE-2023-2804 (CVSS 6.5)

https://nvd.nist.gov/vuln/detail/CVE-2023-2804

Issue has been fixed in libjpeg turbo version 3.0.0

https://github.com/libjpeg-turbo/libjpeg-turbo/releases/tag/3.0.0

Code

n/a

Expected Behavior

n/a

Actual Behavior

n/a

Version of SkiaSharp

2.88.4-preview (Preview)

Last Known Good Version of SkiaSharp

2.88.2 (Previous)

IDE / Editor

Visual Studio (Windows)

Platform / Operating System

All

Platform / Operating System Version

n/a

Devices

n/a

Relevant Screenshots

n/a

Relevant Log Output

n/a

Code of Conduct

  • I agree to follow this project's Code of Conduct
@mattleibow mattleibow added this to the v2.88.6 milestone Aug 22, 2023
@mattleibow
Copy link
Contributor

In the google fork of libjpeg-turbo, they made an optimization to not duplicate a 65k byte table, however, this was never upstreamed. This means that skia may grow a little bit during the fix of this issue. I will try and see if I can get the optimization added upstream and then update again, but for now we will have to lose a bit.

@mattleibow mattleibow changed the title [CYBERSECURITY] Libjpeg turbo current version 2.1.3 in SkiaSharp [CYBERSECURITY] libjpeg-turbo current version 2.1.3 in SkiaSharp Aug 23, 2023
@mattleibow
Copy link
Contributor

Merged this into main and now backporting into the 2.x series. I am a tad bit worried as this is a major jump of the lib - the first in probably years. They may have made some changes, but the author looks to be really break adverse - so it is comforting.

I'll get a preview out ASAP for testing - and then a stable release shortly after.

@RChrisCoble
Copy link
Author

Thanks for the heads up @mattleibow. @jjzhang12 please keep this in mind.

@mattleibow
Copy link
Contributor

Merged into the 2.x branch: #2581

@mattleibow
Copy link
Contributor

There should be a 2.88.6-preview.0.2 version on the preview feed with the new libjpeg-turbo bits.

@ghost ghost locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants