Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Views for Uno WinUI 3 #1787

Closed
beto-rodriguez opened this issue Aug 25, 2021 · 6 comments · Fixed by #2042
Closed

[FEATURE] Views for Uno WinUI 3 #1787

beto-rodriguez opened this issue Aug 25, 2021 · 6 comments · Fixed by #2042
Assignees
Labels
area/SkiaSharp.Views.Uno partner/unoplatform Issues and PRs that are/should being looked at or worked on by the Uno Platform partners. status/help-wanted type/feature-request
Milestone

Comments

@beto-rodriguez
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I re-opened this issue from #1742 to track this implementation @jeromelaban.

Please add Views for Uno WinUI 3 target. As of now I can't use SkiaSharp.Views.Uno in project created with unoapp-winui, nor can I install the SkiaSharp.Views.WinUI into the platform implementations.

Describe the solution you'd like

Add SkiaSharp.Views.UnoWinUI nuget which will depend on Uno.WinUI rather then Uno.UI

@anpin
Copy link
Contributor

anpin commented Jan 6, 2022

hi @jeromelaban, is there any update on this?

@jeromelaban
Copy link
Contributor

Not at this point, but pieces are in place for the work to continue.

@anpin
Copy link
Contributor

anpin commented Feb 13, 2022

I've started putting this together

@anpin
Copy link
Contributor

anpin commented Feb 18, 2022

Unfortunately experience with bleeding edge tooling was frustrating for me. At first both cake and vs2022-preview were telling me that some workloads are not installed (e.g. macos or ios) even though I could see them in dotnet and they were updated, so I had to reinstall dotnet workloads multiple times and removed older sdk's until msbuild somehow recognized all workloads and started to build. Then I've put up new view projects and samples targeting Uno.WinUI and referencing all the same files as current Uno projects, but with conditional compilation to allow different using references for WinUI. Then I realized that I shouldn't just copy project structure for existing Uno views and instead should create a multi-targeted project like Maui views has, so I redo that part. At this point I was faced with Unable to map the following RuntimeIdentifier values to a target architecture: win10-arm-aot;win10-arm64-aot;win10-x86-aot;win10-x64-aot which I couldn't really understand how to fix and VS2022 preview update has arrived, so I decided to try it out. So now msbuild doesn't recognize installed workloads again. I tried to remove not preview version of VS2022 as well as dotnet 6.0.200 sdk installed from binary, so only the VS 17.2.0 Preview 1.0 with it's bundled sdk would be left on my machine, but it still shows that workloads are missing even though "dotnet workload list" shows every needed piece. As I'm writing this I see that there is now dotnet 7 preview, so I'll try to use that instead of 6.0.200.
(P.S. plus the same evening I wrote my previous comment I've got covid with high fewer on next day and I'm not yet fully recovered, so my judgement is a little off)
image

@anpin
Copy link
Contributor

anpin commented Feb 18, 2022

just found a new blog post from MAUI team where they suggest to reinstall previews and .net 6 altogether in case of any issue, so that is what I'm going to do now

EDIT: full reinstall of Visual Studio 2022 preview did not helped

EDIT 2: removing workloads via dotnet cli from clean vs2022 preview install and reinstalling them via cli did the job

@mattleibow
Copy link
Contributor

This feature request is now a feature complete! #2042

@mattleibow mattleibow linked a pull request May 27, 2022 that will close this issue
4 tasks
@mattleibow mattleibow added this to the v2.88.1 milestone May 27, 2022
@mattleibow mattleibow moved this to Done in SkiaSharp Backlog May 27, 2022
@mattleibow mattleibow added status/help-wanted type/feature-request area/SkiaSharp.Views.Uno partner/unoplatform Issues and PRs that are/should being looked at or worked on by the Uno Platform partners. labels May 27, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/SkiaSharp.Views.Uno partner/unoplatform Issues and PRs that are/should being looked at or worked on by the Uno Platform partners. status/help-wanted type/feature-request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants